feat: add empty state for Tags #24702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughhhh
force-pushed
the
tags-empty-state
branch
from
1dfdb72
to
9556352
Compare
Codecov Report
@@ Coverage Diff @@
## master #24702 +/- ##
==========================================
- Coverage 68.84% 68.84% -0.01%
==========================================
Files 1902 1902
Lines 73997 73998 +1
Branches 8195 8195
==========================================
Hits 50944 50944
- Misses 20934 20935 +1
Partials 2119 2119
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…ags-empty-state
…ags-empty-state
| @@ -43,6 +43,21 @@ import { Tag as AntdTag } from 'antd'; | |||
| import { Tag } from 'src/views/CRUD/types'; | |||
| import TagCard from 'src/features/tags/TagCard'; | |||
|
|
|||
| const emptyState = { | |||
| title: t('No Tags created'), | |||
| image: 'dashboard.svg', | |||
There was a problem hiding this comment.
Do we have a different image to use here?
There was a problem hiding this comment.
yes but this is what @kasiazjc wanted for the empty for tags
betodealmeida
approved these changes
Jul 27, 2023
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adding proper empty states for Tags
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION